-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roxygen fix #19
Roxygen fix #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping us in the loop, sadly I don't know enough R to review fully, will wait for somebody else to review.
Do you have a way to test these changes? i.e. did you locally test it on some code or copy paste it into exercises to check it works correctly? Thank you!
@TimSangster No worries whatsoever! And yes, I copied the functions into the SCTs and the exercises seem to be passing! |
@richierocks I've added some fixes to the package check functions, as well as the unused equal check functions. The tests in test-check-roxy.R seem to be passing locally right now! Please let me know if the functions are still failing on your end! Thank you! |
…into roxygen_fix
I spotted some tests that were being skipped in the latest testthat. Fixing those meant I found a few cases where the state wasn't being returned from the check function. And there was some gnarly sapply() code I'd written years ago that I swapped out for cleaner purrr code. All looking good now, and test are passing. @TimSangster Merge at your leisure. |
I've mainly made two changes to the
roxygen
SCTs:registry
argument inparse_text()
(used inextract_roxygen_from_code()
).roxygen
no longer allows us to directly index the parsed blocks. I'm guessing this might have something to do with our removal ofregistry
. Therefore, I resorted to using the block functions inroxygen
to extract tags from the state.Most likely, there's a better way to do this (tag functions might be something worth digging into). That being said, I've tested out the updated SCTs in Teach and everything seems to be working fine! Please let me know if this seems like a valid solution to you!