Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenRefine 3.4 strips whitespace by default #245

Closed
MikeTrizna opened this issue May 20, 2020 · 4 comments
Closed

OpenRefine 3.4 strips whitespace by default #245

MikeTrizna opened this issue May 20, 2020 · 4 comments
Labels
help wanted Looking for Contributors openrefine-3.4.1 Issue to update lesson to meet version 3.4.1 of OpenRefine type:discussion Discussion or feedback about the lesson

Comments

@MikeTrizna
Copy link

I know that the setup instructions here specify using version 3.2, but I got excited that version 3.4 beta bundles Java in both the Windows and Mac installers. Dealing with Java has been our most common headache, so we decided to give the new version a shot for our most recent workshop.

Everything was going well, until we got to the splitting section in Lesson 1. Only the learners with old versions were getting blank columns. It turns out that version 3.4 added a (super-useful) default feature to CSV import: "Trim leading & trailing whitespace from strings". See the screenshot below:

image

Nothing to change in the lesson material now since the lesson is written for 3.2, but something to keep an eye on...

Otherwise, the rest of the lesson seemed to work on 3.4, but we didn't cover all of the episodes.

@troub1
Copy link
Contributor

troub1 commented Sep 17, 2020

I came here to report this same thing. For now, my planned "solution" is to just have them uncheck that box on import. So I don't know if it would be good to simply add that stipulation to the lesson? I can also see how it's easy enough to strip spaces later if you have to, and stripping things out on import (and changing the underlying data) before you've even looked at it makes me a little uneasy, so it seems like it's technically not even best practice to enable an option like that. But then again, it's leading/trailing whitespace, so very unlikely to be actual data...

Either way, I think something needs to be added to the lesson script about it. I also think the setup instructions are unclear regarding the specific version, because there's the instructions that you link to but also these instructions in the lesson: https://datacarpentry.org/OpenRefine-ecology-lesson/setup.html that say "Download the software....Select the most recent version of OpenRefine." So that's how we ended up with 3.4. I also had someone for whom the regular version wouldn't work, so they had to download the bundled Java one, and that was a handy quick fix!

@villanueval
Copy link
Contributor

Version 3.4 added this option, turned on by default (OpenRefine/OpenRefine#791, release notes for OpenRefine 3.4).

There are a couple of options that have been suggested. Please vote by clicking on the option you prefer or enter your feedback as a comment:


@villanueval villanueval added type:discussion Discussion or feedback about the lesson help wanted Looking for Contributors labels May 28, 2021
@villanueval villanueval added the openrefine-3.4.1 Issue to update lesson to meet version 3.4.1 of OpenRefine label Jun 11, 2021
villanueval added a commit that referenced this issue Jun 16, 2021
@villanueval
Copy link
Contributor

Section removed and trim behavior noted in section on opening the file.

@MikeTrizna
Copy link
Author

🙌

villanueval added a commit that referenced this issue Sep 17, 2021
Not sure how but seems a commit brought this section again.
villanueval added a commit that referenced this issue Sep 17, 2021
zkamvar pushed a commit that referenced this issue May 9, 2023
zkamvar pushed a commit that referenced this issue May 9, 2023
Not sure how but seems a commit brought this section again.
zkamvar pushed a commit that referenced this issue May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Looking for Contributors openrefine-3.4.1 Issue to update lesson to meet version 3.4.1 of OpenRefine type:discussion Discussion or feedback about the lesson
Projects
None yet
Development

No branches or pull requests

3 participants