-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR to address bioconductor lesson issues from first beta #167
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a1f23e6
Address #163 via figure path update
naupaka e091450
Address #168 - header level incorrect
naupaka 16898c4
Address header level problem from #169
naupaka 2d0ad96
Remove html comment left over from development
naupaka cb8c412
Address #170 and #173 by revising intro to bioc lesson
naupaka fbcc696
Fix typos
naupaka 475c54c
Merge branch 'main' of github.com:datacarpentry/genomics-r-intro into…
naupaka 937cd07
Address #185 and #186
naupaka 236da2a
Address #187 by adding callout tip
naupaka e5c831b
Address #188 with a callout warning
naupaka 003ce4a
Merge branch 'main' into bioconductor-revisions
naupaka d3aa2f1
Merge branch 'main' of github.com:datacarpentry/genomics-r-intro into…
naupaka c28e053
Remove para on installing from CRAN and adjust wording
naupaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this explanation! I noticed that we mention packages in the "R Basics continued" episode, but we don't explain it to this extent. I wonder if this would be a better fit in an earlier episode than in the Bioconductor one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I think that probably makes sense. This is related to #170 -- if @JasonJWilliamsNY is ok with it I can pull this description out from here, and do a PR of the content on the R Basic continued lesson.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind -- might as well move fast and break things, eh? I pulled out the paragraph in commit c28e053 and will PR it to the earlier lesson separately. @ytakemon let me know if there are any other adjustments you think I should make or if this is ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Merging.