Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update non-text facet descriptions #156

Merged
merged 1 commit into from
May 31, 2023

Conversation

bencomp
Copy link
Contributor

@bencomp bencomp commented May 24, 2023

This fixes #94. I started to fix the broken link, but found that I could try to improve the "More on facets" callout with other changes.

  • Use "Other types of Facets" as heading;
  • Rephrase the introduction about non-text facets;
  • fix the broken link and move the reference to the Ecology lesson inside an instructor note;
  • emphasise that that link goes to a different lesson.

Rephrase the introduction about non-text facets;
fix the broken link and move the reference to the Ecology lesson
inside an instructor note;
emphasise that that link goes to a different lesson.
@bencomp bencomp requested a review from efran May 24, 2023 15:03
@github-actions
Copy link

github-actions bot commented May 24, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/openrefine-socialsci/compare/md-outputs..md-outputs-PR-156

The following changes were observed in the rendered markdown documents:

 02-working-with-openrefine.md | 27 ++++++++++++++++++++-------
 md5sum.txt                    |  2 +-
 2 files changed, 21 insertions(+), 8 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-05-24 15:05:42 +0000

github-actions bot pushed a commit that referenced this pull request May 24, 2023
@bencomp bencomp merged commit 1d3ee56 into datacarpentry:main May 31, 2023
3 checks passed
@bencomp bencomp deleted the 94-broken-facets-link branch May 31, 2023 09:00
@bencomp bencomp removed the request for review from efran May 31, 2023 09:00
github-actions bot pushed a commit that referenced this pull request May 31, 2023
Auto-generated via {sandpaper}
Source  : 1d3ee56
Branch  : main
Author  : Ben Companjen <ben@companjen.name>
Time    : 2023-05-31 09:00:20 +0000
Message : Merge pull request #156 from bencomp/94-broken-facets-link

Update non-text facet descriptions
github-actions bot pushed a commit that referenced this pull request May 31, 2023
Auto-generated via {sandpaper}
Source  : 14568c1
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-05-31 09:02:05 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 1d3ee56
Branch  : main
Author  : Ben Companjen <ben@companjen.name>
Time    : 2023-05-31 09:00:20 +0000
Message : Merge pull request #156 from bencomp/94-broken-facets-link

Update non-text facet descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text in Chapter 2 links to Ecology lessons instead of Social Sciences lesson
1 participant