Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ncbi #131

Merged
merged 2 commits into from
Jun 25, 2020
Merged

New ncbi #131

merged 2 commits into from
Jun 25, 2020

Conversation

dpshelio
Copy link
Contributor

@dpshelio dpshelio commented Jun 25, 2020

This reverts the revert of #129 and builds on top of #128, fixing the links that may have required the revert.

I've merged these changes on my fork so I can demonstrate how it looks before this is merged.

This fixes #127

Copy link
Contributor Author

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the changes I've made from what @hoytpr had made in #128. Or see them independently on 03be65c

_episodes/03-ncbi-sra.md Show resolved Hide resolved
dataset.

You should now have a file called `SraRunTable.txt`
**You should now have a file called `SraRunTable.txt`**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed this from a sub-section to text in bold


You should now have a **tab-delimited** file called `SraRunTable.txt`.

**Return to lesson [Examining Data on the NCBI SRA Database](../03-ncbi-sra/index.html#you-should-now-have-a-file-called-sraruntabletxt) and continue.**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the link so it works properly when rendered.

3. Go back to the ['previous page'](https://trace.ncbi.nlm.nih.gov/Traces/study/?acc=SRP064605). At the top of the page and in the **Total** row you will see there are 312 runs, 109.43 Gb data, and 168.81 Gbases of data. Click the 'RunInfo Table' button and save the file locally.
> ## Downloading the Lenski SRA data from the SRA Run Selector Table using the old Run Selector
>
> Go to the [“old Run Selector” instructions](../old-ncbi/index.html) page and return here after downloading your `SraRunTable.txt` file.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd changed the link so it's not absolute to the organisation.

@hoytpr hoytpr merged commit a54b3fc into datacarpentry:gh-pages Jun 25, 2020
@hoytpr
Copy link
Contributor

hoytpr commented Jun 25, 2020

Thanks for all your help @dpshelio and @ewallace! The lesson is much improved by your attention to details. The "anchor" from the old NCBI page to the new NCBI lesson page doesn't seem to be working, but otherwise everything looks great. The anchor works when I render the pages locally on my Win10 machine, but not on GitHub. Maybe we can still work on that.

zkamvar pushed a commit that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SraRunTable.txt downloads as CSV, not TSV
2 participants