Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make suggested cuts to 05-subsetting-data #29

Merged
merged 3 commits into from Jun 12, 2018
Merged

make suggested cuts to 05-subsetting-data #29

merged 3 commits into from Jun 12, 2018

Conversation

ErinBecker
Copy link
Contributor

Makes cuts to data subsetting episode as suggested in #22.

@ErinBecker ErinBecker requested a review from a team June 11, 2018 18:33
@ErinBecker
Copy link
Contributor Author

Note to Maintainers: Please review and merge #28 before this PR. The previous PR re-built the site, so there are a lot of files showing up as modified for this PR that are just piggy-backing on the previous. If you review and merge #28 before this one, you should only see the changes to the subsetting data file.

Copy link
Contributor

@juanfung juanfung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did #28 first, but this PR does include entire site. Looks good, though. Changes to 05-data-subsetting include removing non-unique names, list subsetting, and associated challenges.

@juanfung juanfung merged commit 5a0c529 into datacarpentry:master Jun 12, 2018
zkamvar pushed a commit that referenced this pull request May 4, 2023
make suggested cuts to 05-subsetting-data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants