Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated static raster plots in episode 4 from base R to ggplot #152

Closed
wants to merge 1 commit into from

Conversation

justinmillar
Copy link

Updating lesson 4 for issues #133 based on @achlandeer open PR

@jsta
Copy link
Member

jsta commented Apr 15, 2018

Thanks for this! Unfortunately we need the changes to be in _episodes_rmd/04-raster-calculations-in-r.Rmd not _episodes/04-raster-calculations-in-r.md. Can you port them over?

@ErinBecker
Copy link
Contributor

Thanks @justinmillar for this contribution. I can take care of porting the changes over the the .rmd file in the next couple of days.

@ErinBecker ErinBecker self-assigned this Jun 7, 2018
@ErinBecker
Copy link
Contributor

Taking me longer than expected, as I haven't figured out how to render this lesson locally yet and need to install all the software. This is something I needed to do anyway to make sure a complete novice (me!) can follow the install instructions, so it will be a good check. Once I have everything installed and can render the lesson, I'll move these changes over to the .Rmd file. Thanks for your patience @justinmillar!

@ErinBecker
Copy link
Contributor

Update - it looks like there has been another PR that makes these same changes (base plot to ggplot for episode 4) (#158). Since that PR has already been merged, I'm going to close this one.

Thanks for the contribution @justinmillar. Sorry for the confusion around this PR.

@ErinBecker ErinBecker closed this Jun 19, 2018
fmichonneau pushed a commit that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants