Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggplot-ing episode 02 #156

Merged
merged 9 commits into from
Jun 7, 2018
Merged

Conversation

lachlandeer
Copy link
Contributor

This extends the ggplot-izing I started with #147 into episode 2, inline with goals outlined in #133

I adopted the framework suggested in #155 for rendering hillshades

  • All plots constructed with ggplot
  • Uses dplyr for any data manipulation inside a data.frame() object

This was referenced Apr 22, 2018
@jsta
Copy link
Member

jsta commented May 6, 2018

Looks good to me. I have some of the same suggestions as in #147 (comment). Otherwise, the only thing I see is that we still have a few lines of text that refer to baseplotting with the plot() function.

@lwasser
Copy link
Member

lwasser commented Jun 1, 2018

so what is left to accept this PR @jsta

@ErinBecker
Copy link
Contributor

Thanks for the review @jsta, I'm going to go ahead and merge this under the understanding that, even if not quite complete, this PR is a significant improvement to the episode. Let's make any additional changes in a subsequent PR, to avoid this PR becoming outdated as new contributions come in.

@ErinBecker ErinBecker merged commit ca97a2d into datacarpentry:master Jun 7, 2018
fmichonneau pushed a commit that referenced this pull request Jun 20, 2018
Link LC as for SWC and DC
zkamvar pushed a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants