Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup to episode 11 #220

Merged
merged 4 commits into from
Jul 19, 2018
Merged

Cleanup to episode 11 #220

merged 4 commits into from
Jul 19, 2018

Conversation

ErinBecker
Copy link
Contributor

@ErinBecker ErinBecker commented Jul 18, 2018

This PR continues cleanup to episode 11 as discussed in #165.

The following changes are included.

Episode 11

  • Needs to be ggplotized. Discussed in convert static plotting from base r to ggplot2 #133 Partially addressed in Clean-up to episode 10 and 11 #217
  • Move comments to narrative for stylistic consistency.
  • Remove line starting "If you completed .csv to Shapefile in R you have these plot"
  • Move bullet point extra resources to callout (multiple places)
  • Broken image link at start of "Extract Raster Pixels Values Using Vector Polygons"
  • Sentence fragment - meant to be a section header? "Extract raster information using a polygon boundary."
  • "In this case," used twice in adjoining sentences.
  • data.frame and list should be plain text.
  • Broken header "##Extract Data using x,y Locations"
  • Broken image link in ##Extract Data using x,y Locations section

@ErinBecker
Copy link
Contributor Author

Review appreciated from @datacarpentry/geospatial-maintainers

extent class in `R`</a>.
```{r}
ggplot() +
geom_sf(data = aoi_boundary_HARV, color = "blue") +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you add fill = NA to the first call - geom_sf(data = aoi_boundary_HARV, color = "blue") + you can then move the call so it draws after/over the raster. That way the outline doesn't get cut off

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! I was trying to figure out how to do this and having a heckofa time.

Copy link
Contributor

@obrl-soil obrl-soil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!


mean_tree_height_tower
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a good place to also talk about cellStats()? It can be used to get fast summaries for whole rasters - mean, median, sd etc like cellStats(CHM_HARV, mean, na.rm = TRUE)

@obrl-soil obrl-soil merged commit 7edf473 into datacarpentry:master Jul 19, 2018
@ErinBecker
Copy link
Contributor Author

Thanks @obrl-soil for the review and merge. I added a link to your comments to #165 so I don't forget to address them.

@ErinBecker ErinBecker deleted the later-episodes branch August 16, 2018 23:56
zkamvar pushed a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants