Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode 11 updated by replacing calls to raster and rgdal packages #396

Merged
merged 4 commits into from
Mar 23, 2023

Conversation

albhasan
Copy link
Contributor

Episode 11 updated by replacing calls to raster and rgdal packages with calls to terra package. #368 #363

@github-actions
Copy link

github-actions bot commented Mar 16, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-raster-vector-geospatial/compare/md-outputs..md-outputs-PR-396

The following changes were observed in the rendered markdown documents:

 11-vector-raster-integration.md                    | 208 +++++++++++----------
 ...integration-rendered-compare-data-extents-1.png | Bin 33131 -> 33265 bytes
 ...ntegration-rendered-crop-by-vector-extent-1.png | Bin 191205 -> 190749 bytes
 ...ration-rendered-hist-tree-height-veg-plot-1.png | Bin 5961 -> 6001 bytes
 ...tion-rendered-repeat-compare-data-extents-1.png | Bin 33131 -> 33265 bytes
 md5sum.txt                                         |   2 +-
 6 files changed, 109 insertions(+), 101 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-03-20 20:57:11 +0000

github-actions bot pushed a commit that referenced this pull request Mar 16, 2023
github-actions bot pushed a commit that referenced this pull request Mar 19, 2023
@drakeasberry
Copy link
Contributor

Thank you for the contributions. You have changed some textual references from df = TRUE to raw = FALSE`, but code still references the former. Could you please update the code blocks to match textual descriptions?

@albhasan
Copy link
Contributor Author

My mistake, I'm sorry. I fixed the issue and made a new commit. Thanks!

github-actions bot pushed a commit that referenced this pull request Mar 20, 2023
@drakeasberry
Copy link
Contributor

Thanks @albhasan for making this update

@drakeasberry drakeasberry merged commit 8744982 into datacarpentry:main Mar 23, 2023
github-actions bot pushed a commit that referenced this pull request Mar 23, 2023
Auto-generated via {sandpaper}
Source  : 8744982
Branch  : main
Author  : Drake Asberry <47766074+drakeasberry@users.noreply.github.com>
Time    : 2023-03-23 00:54:55 +0000
Message : Merge pull request #396 from albhasan/m2022q1_e11

Episode 11 updated by replacing calls to raster and rgdal packages
github-actions bot pushed a commit that referenced this pull request Mar 23, 2023
Auto-generated via {sandpaper}
Source  : dc6e65d
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-03-23 01:05:29 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 8744982
Branch  : main
Author  : Drake Asberry <47766074+drakeasberry@users.noreply.github.com>
Time    : 2023-03-23 00:54:55 +0000
Message : Merge pull request #396 from albhasan/m2022q1_e11

Episode 11 updated by replacing calls to raster and rgdal packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants