-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first use of function with side effects needs explaining? #385
Comments
@steltenpower -- I would agree that this is a bit hard to understand for beginners. Personally, I would like to see this changed to some of the functions from the forcats package, such as |
If there is still any interest in making these changes throughout the episode, I would be happy to contribute a pull request! If so, the same section uses, e.g., in line 395 Since these commands use pretty much the same syntax, I would also understand if this change unnecessarily introduces the |
@cgross95 that would be great! Since we have not introduced forcats yet, I would prefer the former but if you are feeling ambitious perhaps we could have a callout with a quick intro to forcats illustrating the alternative, and maybe some other uses. Either way, I'm happy with the explicit use of |
On
levels(respondent_floor_type)[2] <- "brick"
a student said:"if you're not putting the result of the levels function into a variable, what's going on?"
The text was updated successfully, but these errors were encountered: