Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidyverse/Lubridate automatically loaded alongside other packages #501

Closed
AndrzejRomaniuk opened this issue Jan 4, 2024 · 3 comments
Closed
Labels
good first issue Good issue for first-time contributors status:in progress Contributor working on issue

Comments

@AndrzejRomaniuk
Copy link
Contributor

What is the problem?

A minor issue in the "Formatting Dates" subsection of 02:
"We are going to use the package lubridate, which is included in the tidyverse installation but not loaded by default, so we have to load it explicitly with library(lubridate)."

In the newer Tidyverse iterations it is loaded by default, perhaps it is good to take this into consideration, e.g.

"We are going to use the package lubridate, which is included in the tidyverse installation and should be loaded by default. However, if we deal with other installation of tidyverse, we can manually load it by typing library(lubridate)."

Location of problem (optional)

https://datacarpentry.org/r-socialsci/02-starting-with-data.html#formatting-dates

@juanfung
Copy link
Contributor

juanfung commented Jan 4, 2024

@AndrzejRomaniuk thank you for opening this issue, great catch. That sounds like a good fix to me. Would you be willing to submit a pull request with the suggested change?

@juanfung juanfung added status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR good first issue Good issue for first-time contributors labels Jan 4, 2024
@AndrzejRomaniuk
Copy link
Contributor Author

Once am home today I will do it :)

@juanfung juanfung added status:in progress Contributor working on issue and removed status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR labels Jan 4, 2024
@AndrzejRomaniuk
Copy link
Contributor Author

#502

@juanfung juanfung closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for first-time contributors status:in progress Contributor working on issue
Projects
None yet
Development

No branches or pull requests

2 participants