Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema 4.5 - Update bolognese, cleanup. #1053

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Schema 4.5 - Update bolognese, cleanup. #1053

merged 3 commits into from
Dec 6, 2023

Conversation

svogt0511
Copy link
Contributor

@svogt0511 svogt0511 commented Dec 6, 2023

Purpose

Update bolognese to 2.0.2. Revert json-canonification to 0.3.1. Include forgotten test. Minor cleanup.

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@svogt0511 svogt0511 merged commit 9dff073 into master Dec 6, 2023
13 checks passed
@svogt0511 svogt0511 deleted the schema-4.5-r2a branch December 6, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants