Remove request-time indexing to ES

[digitaldogsbody]

Purpose

Stops DOI objects being reindexed during the request, and leaves the work to the existing SQS queue based index job triggered by indexable concern.

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

• Bug fix (non-breaking change which fixes an issue)

• New feature (non-breaking change which adds functionality)

• Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

• Be humble in the language and feedback you give, ask don't tell.
• Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
• Offer suggestions on how to improve code e.g. simplification or expanding clarity.
• Ensure you give reasons for the changes you are proposing.

[richardhallett]

This still needs to happen though. We have to update the minted/updated date

[digitaldogsbody]

I've reinstated this, but without the variable assignment (so rubocop doesn't get mad)

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ ActiveRecord::Deadlocked: Mysql2::Error: Deadlock found when trying to get lock; try restarting transaction DataciteDoisController#update View Issue
• ‼️ ActiveRecord::Deadlocked: Mysql2::Error: Deadlock found when trying to get lock; try restarting transaction DataciteDoisController#create View Issue

_{Did you find this useful? React with a 👍 or 👎}