Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prefix 500 status error #1180

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

wendelfabianchinsamy
Copy link
Contributor

@wendelfabianchinsamy wendelfabianchinsamy commented Apr 19, 2024

Purpose

closes: datacite/datacite#2109

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads
Copy link
Contributor

jrhoads commented Apr 19, 2024

Can you add a test for this potentially based on the original bug report?

@wendelfabianchinsamy
Copy link
Contributor Author

Can you add a test for this potentially based on the original bug report?

We already have a bunch of specs testing the 404 scenario. The reason this bug exists is because this file was deleted from the repo during the Rails 7 upgrade.

@jrhoads
Copy link
Contributor

jrhoads commented Apr 19, 2024

Can you add a test for this potentially based on the original bug report?

We already have a bunch of specs testing the 404 scenario. The reason this bug exists is because this file was deleted from the repo during the Rails 7 upgrade.

Ahh. I see. It's a 500 error, not something that should happen in the course of the applications function, nor something we should be expecting (as tests do).

@wendelfabianchinsamy wendelfabianchinsamy merged commit 89d22aa into master Apr 19, 2024
25 of 26 checks passed
@wendelfabianchinsamy wendelfabianchinsamy deleted the fix-prefix-500-bug branch April 19, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Including a non-existant prefix at the /prefixes endpoint results in 500 error
3 participants