Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements raidRegistry client_type for Client #1185

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

codycooperross
Copy link
Contributor

@codycooperross codycooperross commented Apr 23, 2024

Purpose

Implements raidRegistry client_type for Client model.

closes: datacite/datacite#2114

Approach

  • Adds raidRegistry to permissable client_types
  • Adds a formatted title for aggregations

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@codycooperross codycooperross merged commit 83ab38d into master May 7, 2024
13 checks passed
@codycooperross codycooperross deleted the raid-registry branch May 7, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lupo mods and testing
3 participants