Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rspec test and performance fix for as indexed json method #1200

Merged
merged 9 commits into from
Jun 20, 2024

Conversation

ashwinisukale
Copy link
Contributor

Purpose

closes: #1166

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@ashwinisukale ashwinisukale changed the title Performance/fix as indexed json queries Rspec test for as indexed json method Jun 20, 2024
@ashwinisukale ashwinisukale changed the title Rspec test for as indexed json method Rspec test and performance fix for as indexed json method Jun 20, 2024
@ashwinisukale ashwinisukale requested a review from a team June 20, 2024 14:11
@ashwinisukale ashwinisukale merged commit 9a43ab1 into master Jun 20, 2024
13 checks passed
@ashwinisukale ashwinisukale deleted the performance/fix-as-indexed-json-queries branch June 20, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test around N+1 issues we fixed
3 participants