Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elasticsearch-rails lib to 7.2.1 #1204

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

richardhallett
Copy link
Contributor

Purpose

For compatability fixes with Ruby 3

Fixes specifically the import rake task

Approach

See: https://github.com/elastic/elasticsearch-rails/releases/tag/v7.2.1

Open Questions and Pre-Merge TODOs

N/A

Learning

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

For compatability fixes with Ruby 3
@richardhallett richardhallett requested a review from a team July 1, 2024 18:11
@richardhallett richardhallett self-assigned this Jul 1, 2024
@richardhallett richardhallett merged commit 8511651 into master Jul 2, 2024
13 checks passed
@richardhallett richardhallett deleted the upgrade_elasticsearch_latest_7x branch July 2, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants