Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 274 generate sources same table name #309

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

BAntonellini
Copy link
Collaborator

No description provided.

@ssassi
Copy link
Contributor

ssassi commented Jan 30, 2023

Action failed:

            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'```

@BAntonellini BAntonellini changed the title Fix issue 274: generate sources same table name fix issue 274 generate sources same table name Jan 30, 2023
@BAntonellini
Copy link
Collaborator Author

Action failed:

            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'```

@ssassi looks quite fresh: https://stackoverflow.com/questions/75281731/pre-commit-fails-to-install-isort-5-10-1-with-error-runtimeerror-the-poetry-co

upgraded isort's pre-commit hook to the latest revision and now everything's passing

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023

Codecov Report

Base: 32.36% // Head: 44.66% // Increases project coverage by +12.29% 🎉

Coverage data is based on head (398ccd1) compared to base (cc3b063).
Patch coverage: 31.90% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #309       +/-   ##
===========================================
+ Coverage   32.36%   44.66%   +12.29%     
===========================================
  Files          28       34        +6     
  Lines        2249     2718      +469     
===========================================
+ Hits          728     1214      +486     
+ Misses       1521     1504       -17     
Flag Coverage Δ
unittests 44.66% <31.90%> (+12.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dbt_coves/core/main.py 49.33% <ø> (ø)
dbt_coves/tasks/dbt/main.py 42.18% <0.00%> (ø)
dbt_coves/tasks/generate/properties.py 33.33% <0.00%> (-1.10%) ⬇️
dbt_coves/tasks/generate/templates.py 42.22% <ø> (ø)
dbt_coves/tasks/setup/git.py 21.05% <0.00%> (ø)
dbt_coves/tasks/setup/utils.py 44.44% <0.00%> (-7.94%) ⬇️
dbt_coves/utils/airbyte_api.py 20.40% <0.00%> (ø)
dbt_coves/utils/log.py 82.35% <ø> (-0.99%) ⬇️
dbt_coves/utils/flags.py 40.96% <10.63%> (+25.81%) ⬆️
dbt_coves/tasks/extract/airbyte.py 24.11% <13.04%> (+0.45%) ⬆️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…nto fix-274-generate-sources-same-table-name
@ssassi ssassi merged commit a3b792b into main Jan 31, 2023
@ssassi ssassi deleted the fix-274-generate-sources-same-table-name branch January 31, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants