-
Notifications
You must be signed in to change notification settings - Fork 1.2k
/
redis.go
262 lines (226 loc) · 6.66 KB
/
redis.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
// Unless explicitly stated otherwise all files in this repository are licensed
// under the Apache License Version 2.0.
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-2020 Datadog, Inc.
package obfuscate
import (
"strings"
"github.com/DataDog/datadog-agent/pkg/trace/pb"
)
// redisTruncationMark is used as suffix by tracing libraries to indicate that a
// command was truncated.
const redisTruncationMark = "..."
const maxRedisNbCommands = 3
// Redis commands consisting in 2 words
var redisCompoundCommandSet = map[string]bool{
"CLIENT": true, "CLUSTER": true, "COMMAND": true, "CONFIG": true, "DEBUG": true, "SCRIPT": true}
// quantizeRedis generates resource for Redis spans
// TODO(gbbr): Refactor this method to use the tokenizer and
// remove "compactWhitespaces". This method is buggy when commands
// contain quoted strings with newlines.
func (*Obfuscator) quantizeRedis(span *pb.Span) {
query := compactWhitespaces(span.Resource)
var resource strings.Builder
truncated := false
nbCmds := 0
for len(query) > 0 && nbCmds < maxRedisNbCommands {
var rawLine string
// Read the next command
idx := strings.IndexByte(query, '\n')
if idx == -1 {
rawLine = query
query = ""
} else {
rawLine = query[:idx]
query = query[idx+1:]
}
line := strings.Trim(rawLine, " ")
if len(line) == 0 {
continue
}
// Parse arguments
args := strings.SplitN(line, " ", 3)
if strings.HasSuffix(args[0], redisTruncationMark) {
truncated = true
continue
}
command := strings.ToUpper(args[0])
if redisCompoundCommandSet[command] && len(args) > 1 {
if strings.HasSuffix(args[1], redisTruncationMark) {
truncated = true
continue
}
command += " " + strings.ToUpper(args[1])
}
// Write the command representation
resource.WriteByte(' ')
resource.WriteString(command)
nbCmds++
truncated = false
}
if nbCmds == maxRedisNbCommands || truncated {
resource.WriteString(" ...")
}
span.Resource = strings.Trim(resource.String(), " ")
}
const redisRawCommand = "redis.raw_command"
// obfuscateRedis obfuscates arguments inside the given span's "redis.raw_command" tag, if it exists
// and is non-empty.
func (*Obfuscator) obfuscateRedis(span *pb.Span) {
if span.Meta == nil || span.Meta[redisRawCommand] == "" {
// nothing to do
return
}
t := newRedisTokenizer([]byte(span.Meta[redisRawCommand]))
var (
str strings.Builder
cmd string
args []string
)
for {
tok, typ, done := t.scan()
switch typ {
case redisTokenCommand:
// new command starting
if cmd != "" {
// a previous command was buffered, obfuscate it
obfuscateRedisCmd(&str, cmd, args...)
str.WriteByte('\n')
}
cmd = tok
args = args[:0]
case redisTokenArgument:
args = append(args, tok)
}
if done {
// last command
obfuscateRedisCmd(&str, cmd, args...)
break
}
}
span.Meta[redisRawCommand] = str.String()
}
func obfuscateRedisCmd(out *strings.Builder, cmd string, args ...string) {
out.WriteString(cmd)
if len(args) == 0 {
return
}
out.WriteByte(' ')
switch strings.ToUpper(cmd) {
case "APPEND", "GETSET", "LPUSHX", "GEORADIUSBYMEMBER", "RPUSHX",
"SET", "SETNX", "SISMEMBER", "ZRANK", "ZREVRANK", "ZSCORE":
// Obfuscate 2nd argument:
// • APPEND key value
// • GETSET key value
// • LPUSHX key value
// • GEORADIUSBYMEMBER key member radius m|km|ft|mi [WITHCOORD] [WITHDIST] [WITHHASH] [COUNT count] [ASC|DESC] [STORE key] [STOREDIST key]
// • RPUSHX key value
// • SET key value [expiration EX seconds|PX milliseconds] [NX|XX]
// • SETNX key value
// • SISMEMBER key member
// • ZRANK key member
// • ZREVRANK key member
// • ZSCORE key member
obfuscateRedisArgN(args, 1)
case "HSET", "HSETNX", "LREM", "LSET", "SETBIT", "SETEX", "PSETEX",
"SETRANGE", "ZINCRBY", "SMOVE", "RESTORE":
// Obfuscate 3rd argument:
// • HSET key field value
// • HSETNX key field value
// • LREM key count value
// • LSET key index value
// • SETBIT key offset value
// • SETEX key seconds value
// • PSETEX key milliseconds value
// • SETRANGE key offset value
// • ZINCRBY key increment member
// • SMOVE source destination member
// • RESTORE key ttl serialized-value [REPLACE]
obfuscateRedisArgN(args, 2)
case "LINSERT":
// Obfuscate 4th argument:
// • LINSERT key BEFORE|AFTER pivot value
obfuscateRedisArgN(args, 3)
case "GEOHASH", "GEOPOS", "GEODIST", "LPUSH", "RPUSH", "SREM",
"ZREM", "SADD":
// Obfuscate all arguments after the first one.
// • GEOHASH key member [member ...]
// • GEOPOS key member [member ...]
// • GEODIST key member1 member2 [unit]
// • LPUSH key value [value ...]
// • RPUSH key value [value ...]
// • SREM key member [member ...]
// • ZREM key member [member ...]
// • SADD key member [member ...]
if len(args) > 1 {
args[1] = "?"
args = args[:2]
}
case "GEOADD":
// Obfuscating every 3rd argument starting from first
// • GEOADD key longitude latitude member [longitude latitude member ...]
obfuscateRedisArgsStep(args, 1, 3)
case "HMSET":
// Every 2nd argument starting from first.
// • HMSET key field value [field value ...]
obfuscateRedisArgsStep(args, 1, 2)
case "MSET", "MSETNX":
// Every 2nd argument starting from command.
// • MSET key value [key value ...]
// • MSETNX key value [key value ...]
obfuscateRedisArgsStep(args, 0, 2)
case "CONFIG":
// Obfuscate 2nd argument to SET sub-command.
// • CONFIG SET parameter value
if strings.ToUpper(args[0]) == "SET" {
obfuscateRedisArgN(args, 2)
}
case "BITFIELD":
// Obfuscate 3rd argument to SET sub-command:
// • BITFIELD key [GET type offset] [SET type offset value] [INCRBY type offset increment] [OVERFLOW WRAP|SAT|FAIL]
var n int
for i, arg := range args {
if strings.ToUpper(arg) == "SET" {
n = i
}
if n > 0 && i-n == 3 {
args[i] = "?"
break
}
}
case "ZADD":
// Obfuscate every 2nd argument after potential optional ones.
// • ZADD key [NX|XX] [CH] [INCR] score member [score member ...]
var i int
loop:
for i = range args {
if i == 0 {
continue // key
}
switch args[i] {
case "NX", "XX", "CH", "INCR":
// continue
default:
break loop
}
}
obfuscateRedisArgsStep(args, i, 2)
default:
// Obfuscate nothing.
}
out.WriteString(strings.Join(args, " "))
}
func obfuscateRedisArgN(args []string, n int) {
if len(args) > n {
args[n] = "?"
}
}
func obfuscateRedisArgsStep(args []string, start, step int) {
if start+step-1 >= len(args) {
// can't reach target
return
}
for i := start + step - 1; i < len(args); i += step {
args[i] = "?"
}
}