Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: excluding Ping from database tracing #178

Closed
MDrollette opened this issue Feb 9, 2018 · 3 comments
Closed

database/sql: excluding Ping from database tracing #178

MDrollette opened this issue Feb 9, 2018 · 3 comments
Labels
apm:ecosystem contrib/* related feature requests or bugs

Comments

@MDrollette
Copy link

Would it be reasonable to make it configurable whether or not the Ping() call is traced on the DB conn? In my case Ping() is used in a service-level health check with a high call frequency, and those traces are just noise.

@gbbr gbbr changed the title Excluding Ping from database tracing database:sql: excluding Ping from database tracing Feb 10, 2018
@gbbr gbbr added apm:ecosystem contrib/* related feature requests or bugs feature-request labels Feb 10, 2018
@gbbr gbbr changed the title database:sql: excluding Ping from database tracing database/sql: excluding Ping from database tracing Feb 10, 2018
@gbbr
Copy link
Contributor

gbbr commented Feb 12, 2018

@MDrollette I think you should be able to ignore those traces by configuring the agent. See here. Please let me know if that fixes it for you.

@MDrollette
Copy link
Author

ah, great. I didn't know that was a feature. It would still be preferable to not send them to the agent at all, since they have such high frequency, but I think that ignore list will be acceptable.

@gbbr
Copy link
Contributor

gbbr commented Feb 12, 2018

Great! If that is acceptable, then please close this issue. If not, let us know and we'll try and find another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

No branches or pull requests

2 participants