Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtrace/tracer: specifying host only as agent address has unexpected results #210

Closed
gbbr opened this issue Apr 11, 2018 · 0 comments
Closed

ddtrace/tracer: specifying host only as agent address has unexpected results #210

gbbr opened this issue Apr 11, 2018 · 0 comments
Assignees
@gbbr
Labels
bug unintended behavior that has to be fixed help wanted

Comments

@gbbr
Copy link
Contributor

gbbr commented Apr 11, 2018

When a host only (no port) is given to the tracer.WithAgentAddr configuration unexpected results happen because of the SplitHostPort return value. This needs to be handled differently (better).
@gbbr gbbr added bug unintended behavior that has to be fixed help wanted labels Apr 11, 2018
@gbbr gbbr self-assigned this Apr 11, 2018
@gbbr gbbr mentioned this issue Jun 14, 2018
Merged
@gbbr gbbr closed this as completed in #258 Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbbr gbbr

Labels
bug unintended behavior that has to be fixed help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbbr