-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: new operation command_execution
#2589
Comments
If I understand correctly, the problem is that the span contains a error where the command likely executed normally (when |
@cataphract Hi! I am sorry I misunderstood how it works 👍 I think I understand the purpose of this new feature and it can be quite useful actually. At the moment I am missing a stack trace to understand where the error comes from but that does not sound doable. And you're right for ➡️ I am sorry for the noise, I am closing that issue 🙏 |
We have encountered the same and that's precisely the concern in our case. Null does not indicate an error, however it's being traced as such. Well, not always. We are using Symfony commands via cron (which looks to be the case for @B-Galati as well) and there are a number of functionality/mode checks using shell_exec. However, there appears to be a nuance I am not understanding. Not all DD_TRACE_CLI_ENABLED=1 DD_SERVICE=test_cli php -r 'var_dump(shell_exec("export foo=bar"));'
# NULL Additionally, just to check, there is no change in the trace even if there is indeed an error with the DD_TRACE_CLI_ENABLED=1 DD_SERVICE=test_cli php -r 'var_dump(shell_exec("cat /file/does/not/exist"));'
# cat: /file/does/not/exist: No such file or directory
# NULL I'm not sure which criteria, configuration, or invocation method with Information about my setup withinPHP VersionPHP 8.2.18 (cli) (built: Apr 11 2024 20:36:27) (NTS) Tracer or profiler version0.99.1 Installed Extensions
ddtrace Info
|
Bug report
Hi!
Since we upgraded to version 0.98.1 we have a new operation called
command_execution
that creates some noise because it contains traces with very very few information. It's not possible to understand the command that was run for example.For the moment we disabled it with
DD_TRACE_EXEC_ENABLED=false
.Here are some screenshots:
PHP version
8.3.3
Tracer or profiler version
0.98.1
Installed extensions
No response
Output of
phpinfo()
No response
Upgrading from
0.96.0
The text was updated successfully, but these errors were encountered: