Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Missing instrumentation for batched AMQP publishing #2644

Closed
lcobucci opened this issue Apr 26, 2024 · 0 comments · Fixed by #2659
Closed

[Feature] Missing instrumentation for batched AMQP publishing #2644

lcobucci opened this issue Apr 26, 2024 · 0 comments · Fixed by #2659

Comments

@lcobucci
Copy link
Contributor

lcobucci commented Apr 26, 2024

Describe the feature you'd like

We use batch operations in our systems and I noticed that we have no visibility of what's happening there after we removed our custom instrumentation in favour of the one provided by ext-ddtrace.

Would it be possible to add instrumentation for the following methods on the AMQPIntegration:

  • PhpAmqpLib\Channel\AMQPChannel::batch_basic_publish()
  • PhpAmqpLib\Channel\AMQPChannel::publish_batch()
  • PhpAmqpLib\Channel\AMQPChannel::wait_for_pending_acks()

Is your feature request related to a problem?

No response

Describe alternatives you've considered

No response

Additional context

No response

lcobucci added a commit to lcobucci/dd-trace-php that referenced this issue May 8, 2024
This fixes DataDog#2644 by configuring the extension to trace the necessary
methods.
lcobucci added a commit to lcobucci/dd-trace-php that referenced this issue May 13, 2024
This fixes DataDog#2644 by configuring the extension to trace the necessary
methods.
PROFeNoM pushed a commit that referenced this issue May 13, 2024
This fixes #2644 by configuring the extension to trace the necessary
methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant