New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isoformat(T) bug #32

Open

drdee wants to merge 1 commit into datadotworld:master from wealthsimple:isoformat-bug

drdee commented Apr 26, 2019

This issue is caused by the line https://github.com/datadotworld/tap-redshift/blob/master/tap_redshift/__init__.py#L280
isoformat('T') only works on datetime objects not date objects.

import datetime
today = datetime.date.today()
today.isoformat()
'2019-04-26'
today.isoformat('T')
Traceback (most recent call last):
File "", line 1, in
TypeError: isoformat() takes no arguments (1 given)
now = datetime.datetime.now()
now.isoformat('T')
'2019-04-26T11:56:49.223151'
now.isoformat()
'2019-04-26T11:56:49.223151'


          Fix isoformat(T) bug

6b50f4c

MortenHegewald approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment