Enable usage of Sequence in named_data.py #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This should probably wait until successful completion of #109. |
|
@orgadish could you please fix the conflicts in this PR so that we could merge it as well and release both changes under one version. |
added 7 commits
August 2, 2022 14:29
…d_data_seq-on-master � Conflicts: � named_data.py
…dDataDict class and simplified @named_data logic.
…this), and simplified named_data logic further as a result.
|
@wswld This PR is ready for final review. |
wswld
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #107
All tests in
test_named_data.pypass successfully.