feat!: Use data source for convention and function for generating name #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevie-
reviewed
May 30, 2024
Comment on lines
+33
to
+39
| max_length = 4 | ||
| }, | ||
| ] | ||
| } | ||
|
|
||
| resource "random_string" "random" { | ||
| length = 16 |
There was a problem hiding this comment.
der randomwert in der convention setzt max_length auf 4
der random_string generiert eine string mit length 16
Schneidet dann designation den Rest ab?
fuerst-ede
reviewed
May 30, 2024
| make | ||
| ``` | ||
|
|
||
| To use the local build version you need tell terraform where to look for it via a terraform config override. |
There was a problem hiding this comment.
[...] you need to tell [...]
fuerst-ede
reviewed
May 30, 2024
|
|
||
| To use the local build version you need tell terraform where to look for it via a terraform config override. | ||
|
|
||
| Create `dev.tfrc` in your terraform code folder (f.e. in [dev.tfrc](./examples/development/dev.tfrc)): |
fuerst-ede
reviewed
May 30, 2024
| page_title: "generate_name function - terraform-provider-designation" | ||
| subcategory: "" | ||
| description: |- | ||
| Generate a name for a convention and with specified parameters |
There was a problem hiding this comment.
"Generate a name for a convention with specified parameters"
fuerst-ede
reviewed
May 30, 2024
| override_special = "/@£$" | ||
| } | ||
|
|
||
| output "name1" { |
There was a problem hiding this comment.
Warum heißt das "name1"? Wäre hier ein sprechenderer Bezeichner möglich / sinnvoll?
fuerst-ede
reviewed
May 30, 2024
| } | ||
|
|
||
| output "name_app" { | ||
| value = designation_name.app.result | ||
| output "name1" { |
There was a problem hiding this comment.
Kann "name1" sprechender benannt werden?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.