feat: add resource and datasource for SSL truststore #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @afrimberger, thank you for your contribution. It lgtm so far, the only thing i noticed missing is the docs for the new resource. Could you please run |
afrimberger
force-pushed
the
feature/ssl-truststore
branch
from
229a9a6
to
14d2bc5
Compare
|
Hi @chris-ruecker, I amended the commit and added the docs. |
stevie-
force-pushed
the
feature/ssl-truststore
branch
from
14d2bc5
to
0cea197
Compare
|
We have split the ssl retrieval into its own DataSource, called nexus_security_ssl. The truststore resource is now only responsible for managing certificates in the truststore. |
chris-ruecker
force-pushed
the
feature/ssl-truststore
branch
from
0f9cdc2
to
32951fc
Compare
|
i will fix the docker tests in a seperated PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managing the SSL truststore is not yet supported by the provider. Hence, the PR :).