Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in subdomain connector feature for Pro versions. #416

Merged
merged 14 commits into from Jan 29, 2024
Merged

Add in subdomain connector feature for Pro versions. #416

merged 14 commits into from Jan 29, 2024

Conversation

btribit
Copy link
Contributor

@btribit btribit commented Jan 18, 2024

Addresses this issue: #368

Allows for the creation of subdomain connectors for docker registries in Pro versions.

@AYDEV-FR
Copy link

I tried this PR on my nexus with a pro license, it works great.

Thank you very much @btribit , let's hope it merges to use the real provider and not your fork.

@btribit
Copy link
Contributor Author

btribit commented Jan 29, 2024

@AYDEV-FR, thank you for the feedback! It has been working well for me as well. Just needs to be reviewed and merged it looks like.

anmoel
anmoel requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@anmoel anmoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btribit please fix the acceptance test templates or accepting my suggestions

internal/acceptance/template-strings-repository-docker.go Outdated Show resolved Hide resolved
internal/acceptance/template-strings-repository-docker.go Outdated Show resolved Hide resolved
internal/acceptance/template-strings-repository-docker.go Outdated Show resolved Hide resolved
@btribit @anmoel
Update internal/acceptance/template-strings-repository-docker.go
6ae2c65 
Co-authored-by: André Möller <development@andre-moeller.eu>
@anmoel
Copy link
Member

anmoel commented Jan 29, 2024

@btribit please update the go-nexus-client dependency in your PR to v1.9.0

btribit and others added 2 commits January 29, 2024 13:18
@btribit
Copy link
Contributor Author

btribit commented Jan 29, 2024

@anmoel , done!

anmoel
anmoel requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@anmoel anmoel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test-pipeline fails. please check your tests. i add a comment at one line
also please add the suggested description so the user can see that the parameter is a pro feature

internal/schema/repository/schema_docker.go Outdated Show resolved Hide resolved
internal/schema/repository/schema_docker.go Outdated Show resolved Hide resolved
internal/services/repository/resource_repository_docker_group_test.go Show resolved Hide resolved
@btribit btribit marked this pull request as draft January 29, 2024 20:28
@btribit btribit requested a review from anmoel January 29, 2024 21:40
@btribit btribit marked this pull request as ready for review January 29, 2024 21:41
anmoel
anmoel approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@anmoel anmoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
lgtm

@anmoel anmoel merged commit 06a1439 into datadrivers:main Jan 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmoel anmoel anmoel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@btribit @AYDEV-FR @anmoel