moving common methods into one parent class #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, accidentally deleted an active branch! |
|
Doesn't compile.... missing imports for List, Calendar, etc. |
|
This isn't urgent and is probably too old to fix easily. I'll take it off the docket for now and fix it up when I have time. |
daisieh
force-pushed
the
test-abstract-describe-step
branch
from
fc488b1
to
6bd1543
Compare
|
@ryscher, this should be good for code review now. |
|
Looks good. Tested ok on vm. |
ryscher
added a commit
that referenced
this pull request
Feb 10, 2016
moving common methods into one parent class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I consolidated the common methods between DescribeDatasetStep and DescribePublicationStep into a parent class, DescribeStep. The remaining methods are still largely similar, but this is as much as I can do without actually going into detailed testing.