Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Famous Last Words faker #171

Merged

Conversation

Tahanima
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #171 (30a08fc) into master (0279d57) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #171   +/-   ##
=========================================
  Coverage     94.47%   94.48%           
- Complexity     1699     1701    +2     
=========================================
  Files           173      174    +1     
  Lines          3623     3628    +5     
  Branches        362      362           
=========================================
+ Hits           3423     3428    +5     
  Misses          105      105           
  Partials         95       95           
Impacted Files Coverage Δ
.../main/java/net/datafaker/service/files/EnFile.java 93.33% <ø> (ø)
src/main/java/net/datafaker/Faker.java 99.47% <100.00%> (+<0.01%) ⬆️
src/main/java/net/datafaker/FamousLastWords.java 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bodiam
Copy link
Contributor

bodiam commented May 25, 2022

Seems you're on a roll! Nice one again, thanks.

Maybe a small hint for next time : we use the RepeatedTest annotation quite a bit, which repeatedly executes the test. A value somewhere between 10-100 repetitions is fine, since that detects incorrect assertions a bit earlier. But this PR is fine, thanks!

@bodiam bodiam merged commit 441e1d7 into datafaker-net:master May 25, 2022
@Tahanima Tahanima deleted the feature/add-famous-last-words-faker branch May 25, 2022 15:49
@Tahanima
Copy link
Contributor Author

Seems you're on a roll! Nice one again, thanks.

You're welcome.

Maybe a small hint for next time : we use the RepeatedTest annotation quite a bit, which repeatedly executes the test. A value somewhere between 10-100 repetitions is fine, since that detects incorrect assertions a bit earlier. But this PR is fine, thanks!

Thank you so much. I'll keep this in mind from next time onward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants