Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken 'Address.streetName' faker for 'bg' locale #253

Merged

Conversation

panilya
Copy link
Collaborator

@panilya panilya commented Jul 25, 2022

Issue related to the problem: #252
PR that shows this problem: #250

@panilya panilya changed the title Fix broken 'Address.streetName faker' for 'bg' locale Fix broken 'Address.streetName' faker for 'bg' locale Jul 25, 2022
@panilya panilya merged commit 702973b into datafaker-net:master Jul 25, 2022
@panilya panilya deleted the fix-bg-locale-street-name-faker branch July 25, 2022 19:14
@snuyanzin
Copy link
Collaborator

snuyanzin commented Jul 25, 2022

I wouldn't say that changing a yaml file is a solution (most likely it is a kind of work around). Moreover that configuration worked before...
We need to guarantee that same configuration should continue working if it worked for 1.4.0 and earlier.
Furthermore it looks like the same issue is actual for other locales like by, ru, uk, may be something else not related to address...

@bodiam
Copy link
Contributor

bodiam commented Jul 26, 2022

Shall we revert 702973b?

@panilya
Copy link
Collaborator Author

panilya commented Jul 26, 2022

Shall we revert 702973b?

I think yes. Sorry about that

@bodiam
Copy link
Contributor

bodiam commented Jul 26, 2022

Don't worry about it, no problem at all!

bodiam added a commit that referenced this pull request Aug 2, 2022
bodiam added a commit that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants