Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make delimiter for latLon and lonLat configurable #258

Merged
merged 1 commit into from Jul 29, 2022

Conversation

snuyanzin
Copy link
Collaborator

The PR makes delimiter for latLon and lonLat configurable. Defaults to ,

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #258 (cb07f7e) into master (f483f29) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #258   +/-   ##
=========================================
  Coverage     94.62%   94.62%           
- Complexity     1877     1879    +2     
=========================================
  Files           192      192           
  Lines          3943     3945    +2     
  Branches        393      393           
=========================================
+ Hits           3731     3733    +2     
  Misses          111      111           
  Partials        101      101           
Impacted Files Coverage Δ
src/main/java/net/datafaker/Address.java 94.44% <100.00%> (+0.32%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@snuyanzin snuyanzin merged commit cb07f7e into datafaker-net:master Jul 29, 2022
@bodiam
Copy link
Contributor

bodiam commented Jul 29, 2022

Just out of interest, did you need this?

@snuyanzin
Copy link
Collaborator Author

This is a part of int/fraction delimiter's in different locales issue.
The problem is ru locale and probably some others.
In this locale comma is a delimiter between int and fraction parts of numbers.
So it's better to have another delimiter in that case.
Also I'm going to fix latitude/longitude to use corresponding delimiter between int and fraction parts of numbers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants