Add Baseball provider #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodiam
reviewed
Nov 10, 2022
| * Generate random components of baseball game, e.g. teams, coaches, positions and players. | ||
| * | ||
| * @author unknown and irakatz | ||
| * @since 0.8.0 |
There was a problem hiding this comment.
Small issue here with the version number, this should be 1.7.0 I think?
There was a problem hiding this comment.
Yeah, I mean 1.7.0. I'll change the version number.
Codecov Report
@@ Coverage Diff @@
## main #548 +/- ##
============================================
+ Coverage 92.65% 92.66% +0.01%
- Complexity 2368 2374 +6
============================================
Files 247 248 +1
Lines 4944 4951 +7
Branches 530 530
============================================
+ Hits 4581 4588 +7
Misses 241 241
Partials 122 122
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Baseball provider under Sport package with issue #547