Skip to content

Add configuration for comma in json, refactor jsontransformer#656

Merged
snuyanzin merged 1 commit intodatafaker-net:mainfrom
snuyanzin:comma
Jan 29, 2023
Merged

Add configuration for comma in json, refactor jsontransformer#656
snuyanzin merged 1 commit intodatafaker-net:mainfrom
snuyanzin:comma

Conversation

@snuyanzin
Copy link
Copy Markdown
Collaborator

No description provided.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Jan 29, 2023

  • Removed jsonassert dependency
  • Changed JsonTransformer to support JSON array output and comma between objects in the same line or not
  • Added tests for new features of JsonTransformer

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 29, 2023

Codecov Report

Merging #656 (3fc2add) into main (10170b2) will increase coverage by 0.11%.
The diff coverage is 87.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #656      +/-   ##
============================================
+ Coverage     92.66%   92.77%   +0.11%     
- Complexity     2624     2625       +1     
============================================
  Files           281      281              
  Lines          5413     5415       +2     
  Branches        590      589       -1     
============================================
+ Hits           5016     5024       +8     
+ Misses          245      241       -4     
+ Partials        152      150       -2     
Impacted Files Coverage Δ
...net/datafaker/transformations/JsonTransformer.java 92.92% <87.50%> (+1.92%) ⬆️
...c/main/java/net/datafaker/providers/base/Text.java 78.81% <0.00%> (+0.84%) ⬆️
...ain/java/net/datafaker/idnumbers/KoKrIdNumber.java 87.50% <0.00%> (+6.25%) ⬆️
...net/datafaker/internal/helper/SingletonLocale.java 85.00% <0.00%> (+10.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 5733999 into datafaker-net:main Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants