Fix non-capturing groups #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd previously used the wrong syntax, luckily it didn't break things. I'm sure there are a ton of places this should be changed further. I'll look at that for another PR. Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #707 +/- ##
============================================
+ Coverage 92.78% 92.79% +0.01%
+ Complexity 2578 2576 -2
============================================
Files 281 281
Lines 5113 5108 -5
Branches 529 529
============================================
- Hits 4744 4740 -4
+ Misses 237 235 -2
- Partials 132 133 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Did "we" give up on what-the-diff? Or has it stopped working? |
No available credits at the moment :( |
|
I just applied for an Open Source plan! I hope we could get accepted, I do think these PR summaries are quite helpful! |
|
Okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd previously used the wrong syntax, luckily it didn't break things.
I'm sure there are a ton of places this should be changed further. I'll look at that for another PR.
Signed-off-by: kingthorin kingthorin@users.noreply.github.com