New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test of deterministic and non deterministic provider's methods #743
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is being added generically, remove it from Oscars?
LGTM
yep, probably makes sense to remove it |
…icAndNonDeterministicProvidersReturnValues
DOH, needs a spotlessapply |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #743 +/- ##
============================================
+ Coverage 92.80% 92.84% +0.03%
- Complexity 2590 2592 +2
============================================
Files 281 281
Lines 5126 5126
Branches 530 530
============================================
+ Hits 4757 4759 +2
+ Misses 241 240 -1
+ Partials 128 127 -1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The PR is aiming to solve #741 for all the providers (not only
OscarMovie
)E.g. it was detected that
Mbti
has same issue.It retrieves all the declared public methods from provider with zero arg and invokes them several times.
The result is expected to be not the same at least for some of the invocations.
As an exception there
Deterministic
annotation added to mark methods which are expected to return same value for any number of invocations.