Add test of deterministic and non deterministic provider's methods#743
Merged
Conversation
PR Summary
|
kingthorin
reviewed
Mar 29, 2023
kingthorin
left a comment
Collaborator
There was a problem hiding this comment.
Since this is being added generically, remove it from Oscars?
LGTM
Collaborator
Author
|
yep, probably makes sense to remove it |
…icAndNonDeterministicProvidersReturnValues
kingthorin
approved these changes
Mar 29, 2023
Collaborator
|
DOH, needs a spotlessapply |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #743 +/- ##
============================================
+ Coverage 92.80% 92.84% +0.03%
- Complexity 2590 2592 +2
============================================
Files 281 281
Lines 5126 5126
Branches 530 530
============================================
+ Hits 4757 4759 +2
+ Misses 241 240 -1
+ Partials 128 127 -1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
snuyanzin
added a commit
to snuyanzin/datafaker
that referenced
this pull request
Apr 17, 2023
snuyanzin
added a commit
to snuyanzin/datafaker
that referenced
this pull request
Apr 17, 2023
snuyanzin
added a commit
that referenced
this pull request
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is aiming to solve #741 for all the providers (not only
OscarMovie)E.g. it was detected that
Mbtihas same issue.It retrieves all the declared public methods from provider with zero arg and invokes them several times.
The result is expected to be not the same at least for some of the invocations.
As an exception there
Deterministicannotation added to mark methods which are expected to return same value for any number of invocations.