New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aviation provider: added more airlines. #765
Aviation provider: added more airlines. #765
Conversation
…tems' into feature/Aviation_provider_more_items # Conflicts: # src/main/resources/en/aviation.yml
Seems the test is failing due to a regex mismatch. |
@@ -18,12 +18,12 @@ void flight_ICAO() { | |||
|
|||
@Test | |||
void flight_IATA() { | |||
assertThat(aviation.flight("IATA")).matches("[A-Z]{2}[0-9]+"); | |||
assertThat(aviation.flight("IATA")).matches("[A-Z|0-9]{2}[0-9]+"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the character class really include pipe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me rephrase, the square brackets shouldn’t include pipe. In either test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I am confused by you comment. I altered the regexp because a flight ID could be like 2B2345 or A97887. Previous data set had no such airlines codes (2B, A9 etc) so the regexp was ok. Now, since a IATA airline code could include a digit the original test may fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, I got your point. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick fix. LGTM!
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #765 +/- ##
============================================
+ Coverage 92.77% 92.82% +0.05%
- Complexity 2604 2633 +29
============================================
Files 282 284 +2
Lines 5161 5202 +41
Branches 533 537 +4
============================================
+ Hits 4788 4829 +41
Misses 245 245
Partials 128 128 see 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The current failure seem unrelated:
I’ll kick the tests off again. |
@kingthorin - seems it fails because of a test for #716 The test uses the aviation provider's data and the "old" regexp. Let me fix that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>
Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>
Added more items under "IATA_airline", "ICAO_airline" and "airline" sections.