Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call for super constructors #795

Merged
merged 1 commit into from Apr 30, 2023
Merged

Conversation

snuyanzin
Copy link
Collaborator

It seems this call was missed

@what-the-diff
Copy link

what-the-diff bot commented Apr 30, 2023

PR Summary

  • Added super() method to constructors
    The code is now updated to include the super() method in the constructors of each class. This allows for proper inheritance and enables cleaner, more readable code.

@codecov-commenter
Copy link

Codecov Report

Merging #795 (b140201) into main (d1880c0) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #795      +/-   ##
============================================
- Coverage     92.54%   92.51%   -0.04%     
+ Complexity     2654     2653       -1     
============================================
  Files           286      286              
  Lines          5274     5274              
  Branches        553      553              
============================================
- Hits           4881     4879       -2     
- Misses          252      253       +1     
- Partials        141      142       +1     
Impacted Files Coverage Δ
...er/providers/entertainment/EntertainmentFaker.java 16.66% <100.00%> (ø)
...n/java/net/datafaker/providers/food/FoodFaker.java 33.33% <100.00%> (ø)
...java/net/datafaker/providers/sport/SportFaker.java 16.66% <100.00%> (ø)
.../datafaker/providers/videogame/VideoGameFaker.java 16.66% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 8edbed3 into datafaker-net:main Apr 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants