Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Add Support For snowflake-connector-python>=3.0.0 #457

Closed
bcodell opened this issue Mar 24, 2023 · 3 comments · Fixed by #593
Closed

Add Support For snowflake-connector-python>=3.0.0 #457

bcodell opened this issue Mar 24, 2023 · 3 comments · Fixed by #593
Assignees
Labels
--dbt Issues/features related to the dbt integration enhancement New feature or request

Comments

@bcodell
Copy link

bcodell commented Mar 24, 2023

Is your feature request related to a problem? Please describe.
Dependencies often found in the same projects as data-diff now require snowflake-connector-python>=3.0.0 but data-diff requires <3.0.0.

Describe the solution you'd like
Update the snowflake-connector-python dependency range to be >=2.7.2, <4.0.0 (or some upper bound above 3.0.0).

Describe alternatives you've considered
N/A

Additional context
There are vulnerabilities identified in snowflake-connector-python<2.8.2

@bcodell bcodell added the enhancement New feature or request label Mar 24, 2023
@dlawin
Copy link
Contributor

dlawin commented Mar 28, 2023

We'll need to update https://github.com/datafold/sqeleton as well

@kylemcnair
Copy link
Contributor

From @bcodell in Locally Optimistic

Circling back to this - it’d still be beneficial to do this, but I found a workaround by removing snowflake as a data-diff extra in my dependency requirements file and explicitly required snowflake-connector-python instead. Technically there’s a version conflict but data-diff still appears to work as expected.

@dlawin dlawin added the --dbt Issues/features related to the dbt integration label May 8, 2023
@dlawin dlawin self-assigned this May 23, 2023
@dlawin
Copy link
Contributor

dlawin commented May 23, 2023

Seeing another report of this. Here is the workaround for now:

# Installing data-diff for snowflake when you have another dependency that requires snowflake-connector-python>=3.0.0

pip install data-diff -U
pip install 'snowflake-connector-python>=3.0.0'

Alternatively in a requirements.txt, something like:

dbt-snowflake>=1.5
data-diff>=0.7.7
snowflake-connector-python>=3.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
--dbt Issues/features related to the dbt integration enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants