Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRITICAL SECURITY ISSUE: vm2 should bee replaced by isolated-vm #1615

Closed
vl4py opened this issue Dec 13, 2023 · 4 comments
Closed

CRITICAL SECURITY ISSUE: vm2 should bee replaced by isolated-vm #1615

vl4py opened this issue Dec 13, 2023 · 4 comments

Comments

@vl4py
Copy link

vl4py commented Dec 13, 2023

Description

vm2 is sensible to sandbox escape attack. Since 3.9.19 the project is now discontinued. The main contributor recommand to migrate to isolated-vm.

@BenBirt
Copy link
Collaborator

BenBirt commented Dec 13, 2023

Thanks. We are aware of the issue.

Currently we do not use vm2 to implement any sandbox/secure computation features. It's now just used as a way to easily execute JavaScript in the way that we need to do implement compilation.

We will replace it at some point.

@vl4py
Copy link
Author

vl4py commented Dec 13, 2023

Thank you for the quick reply

@oikarinen
Copy link

@BenBirt any update on this?

@BenBirt
Copy link
Collaborator

BenBirt commented Feb 2, 2024

No - as above, we do not use vm2 to implement any security boundary. We'll replace it, but that's at low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants