Move concurrency and action retries from project config proto to the CLI #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canberkkoparal
requested changes
Nov 22, 2023
Ekrekr
commented
Nov 22, 2023
tests/api/api.spec.ts
Outdated
| when(mockedDbAdapter.createSchema(anyString(), anyString())).thenResolve(null); | ||
| when( | ||
| mockedDbAdapter.execute(NEW_TEST_GRAPH.actions[0].tasks[0].statement, anything()) | ||
| ).thenResolve({ | ||
| rows: [], | ||
| metadata: { | ||
| bigquery: { | ||
| actionRetryLimit: 1, |
There was a problem hiding this comment.
This doesn't do what I thought it did, will think about the fix
There was a problem hiding this comment.
Fixed, the option just needed to be passed into the runner instead.
Ekrekr
requested review from
canberkkoparal
and removed request for
canberkkoparal
canberkkoparal
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As they are not valid options for
workflow_settings.yaml