Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JS context from SQL files #1672

Merged
merged 6 commits into from Feb 8, 2024
Merged

Remove JS context from SQL files #1672

merged 6 commits into from Feb 8, 2024

Conversation

Ekrekr
Copy link
Contributor

@Ekrekr Ekrekr commented Feb 6, 2024

Update uniqueKey field description while here.

@Ekrekr Ekrekr requested a review from BenBirt February 6, 2024 12:05
BenBirt
BenBirt requested changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@BenBirt BenBirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely to be semantically equivalent you should also add dependencyTargets: ... in the actions.yaml for extreme_weather_programming actions?

core/compilers.ts Outdated Show resolved Hide resolved
@Ekrekr
Copy link
Contributor Author

Ekrekr commented Feb 7, 2024

Surely to be semantically equivalent you should also add dependencyTargets: ... in the actions.yaml for extreme_weather_programming actions?

Done

@Ekrekr Ekrekr requested a review from BenBirt February 7, 2024 17:05
@Ekrekr Ekrekr merged commit 800e36d into main_v3 Feb 8, 2024
4 checks passed
@Ekrekr Ekrekr deleted the remove-sql-js-context branch February 8, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenBirt BenBirt BenBirt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ekrekr @BenBirt