Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable File-Specific Formatting in dataform format #1746

Closed

Conversation

hiracky16
Copy link
Contributor

@hiracky16 hiracky16 commented May 26, 2024

resolves: #1747

Copy link

google-cla bot commented May 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hiracky16 hiracky16 changed the title fix: format options Enable File-Specific Formatting in dataform format May 26, 2024
@hiracky16 hiracky16 closed this May 26, 2024
@hiracky16 hiracky16 reopened this May 26, 2024
@hiracky16 hiracky16 closed this May 26, 2024
@hiracky16 hiracky16 reopened this May 26, 2024
@hiracky16
Copy link
Contributor Author

@BenBirt

I hope this message finds you well.
This is my first pull request to the repository, and I noticed that the CI check has failed.
It appears that the CI process did not run at all, leading to an error.

Could you please help me understand the possible reasons for this issue?
I would like to resolve any problems and ensure that the PR meets the repository's requirements.

cli/index.ts Outdated Show resolved Hide resolved
@Ekrekr
Copy link
Contributor

Ekrekr commented May 28, 2024

@BenBirt

I hope this message finds you well. This is my first pull request to the repository, and I noticed that the CI check has failed. It appears that the CI process did not run at all, leading to an error.

Could you please help me understand the possible reasons for this issue? I would like to resolve any problems and ensure that the PR meets the repository's requirements.

We just updated our CI progress, and you're the first to test it! Unfortunately, it's not working for external contributors, and I'm not sure why...

You can run tests manually for now by running ./scripts/run_tests.

Co-authored-by: Elias Kassell <eliaskassell@gmail.com>
@hiracky16
Copy link
Contributor Author

hiracky16 commented May 28, 2024

@Ekrekr
Thank you for your assistance.

I have accepted your suggestion and would appreciate another review. 🙏
Additionally, I tried running the tests locally, but they seem to be failing.
How can I run tests?

The error message is as follows:

ERROR: /Users/nori/workspace/dataform/test_credentials/BUILD:5:14: Action test_credentials/bigquery.json failed: (Exit 1): gcloud failed: error executing command external/gcloud_sdk/bin/gcloud kms decrypt '--ciphertext-file=test_credentials/bigquery.json.enc' '--plaintext-file=bazel-out/darwin-py2-fastbuild/bin/test_credentials/bigquery.json' ... (remaining 4 arguments skipped)
ERROR: (gcloud.kms.decrypt) PERMISSION_DENIED: Permission 'cloudkms.cryptoKeyVersions.useToDecrypt' denied on resource 'projects/dataform-open-source/locations/global/keyRings/dataform-builder-keyring/cryptoKeys/dataform-builder-key' (or it may not exist).
INFO: Elapsed time: 10.622s, Critical Path: 8.87s
INFO: 19 processes: 17 internal, 2 darwin-sandbox.
FAILED: Build did NOT complete successfully
//common/errors:errors.spec                                           NO STATUS
//common/promises:index.spec                                          NO STATUS
//common/protos:build_test                                            NO STATUS
//common/strings:stringifier.spec                                     NO STATUS
//core:main_test                                                      NO STATUS
//examples:examples_test                                              NO STATUS
//sqlx:format_test                                                    NO STATUS
//sqlx:lexer_test                                                     NO STATUS
//testing:index_test                                                  NO STATUS
//tests/api:api.spec                                                  NO STATUS
//tests/api:projects.spec                                             NO STATUS
//tests/api:utils/cancellable_promise.spec                            NO STATUS
//tests/api:utils/error_parsing.spec                                  NO STATUS
//tests/core:core.spec                                                NO STATUS
//tests/integration:bigquery.spec                                     NO STATUS
//cli:index_test                                                FAILED TO BUILD
//common/flags:build_test                                                PASSED in 0.7s

Executed 1 out of 17 tests: 1 test passes, 1 fails to build and 15 were skipped.
FAILED: Build did NOT complete successfully

@Ekrekr
Copy link
Contributor

Ekrekr commented May 29, 2024

Can you share me your gmail account, and I'll grant you permission to decrypt the secret, and to run the CI/CD? Thanks!

@hiracky16
Copy link
Contributor Author

@Ekrekr
My Gmail account is the same as my GitHub email address. Please share accordingly.
If possible, if you could also share the steps to run the CI/CD after the decrypt is shared.

@hiracky16
Copy link
Contributor Author

@Ekrekr
My Google Account is h.piiice16@gmail.com .
Please grant you permission.

@Ekrekr
Copy link
Contributor

Ekrekr commented Jun 3, 2024

@Ekrekr My Google Account is h.piiice16@gmail.com . Please grant you permission.

Hi Noriaki,

I've granted some permissions for people in the dataform-open-source-contributors Google group. If everything works, you should now be able to:

  • Run ./scripts/run_tests.
  • Re-run the pull-request-trigger failed CI - you might need to accept cla/google first, to get that one green.

Let me know if this works!

Thanks.

@hiracky16
Copy link
Contributor Author

I will reopen the PR because the cla/google CI is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable File-Specific Formatting in dataform format
2 participants