Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Router Link #5

Open
vict0rsch opened this issue Oct 7, 2018 · 4 comments
Open

Use Router Link #5

vict0rsch opened this issue Oct 7, 2018 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@vict0rsch
Copy link
Collaborator

switch from button + onClick to <Link to="...">...</Link>
@vict0rsch vict0rsch added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 7, 2018
@kamry-bowman
Copy link
Contributor

Could I take a swing at this one?

@vict0rsch
Copy link
Collaborator Author

Please do :)

My understanding is that using more is also better for SEO ; any opinion?

@kamry-bowman
Copy link
Contributor

Yes, I think in general you can't rely on web crawlers to interact with your javascript (though people disagree), but Link tags are built on top of tags, and web crawlers are pretty guaranteed to follow those. That's my understanding anyway!

kamry-bowman added a commit to kamry-bowman/metada that referenced this issue Oct 9, 2018
@kamry-bowman
Add Link in Tabs.js (datafornews#5)
4c9eca2
kamry-bowman added a commit to kamry-bowman/metada that referenced this issue Oct 9, 2018
@kamry-bowman
Implement Link on Chip.js and Example.js (datafornews#5)
6434f4a
@kamry-bowman kamry-bowman mentioned this issue Oct 9, 2018
Merged
@vict0rsch
Copy link
Collaborator Author

vict0rsch commented Oct 9, 2018 •
edited
Loading

Yeah makes sense I agree.

Thanks a lot for your effort on <Link>s 👍

@kamry-bowman would you mind doing so on the dev branch? That's where I develop the project right now :)

kamry-bowman added a commit to kamry-bowman/metada that referenced this issue Oct 10, 2018
@kamry-bowman
Remove underline from Link tags (datafornews#5)
9056225
vict0rsch added a commit that referenced this issue Oct 10, 2018
@vict0rsch
Merge pull request #6 from kamry-bowman/link-convert
b55449d 
Use Router Link (#5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vict0rsch @kamry-bowman