Skip to content

Commit

Permalink
chore: remove explain join estimated_rows (#13212)
Browse files Browse the repository at this point in the history
* remove explain join estimated_rows

* sqllogictest
  • Loading branch information
Dousir9 committed Oct 11, 2023
1 parent be202c9 commit 4567c4c
Show file tree
Hide file tree
Showing 4 changed files with 73 additions and 74 deletions.
8 changes: 4 additions & 4 deletions src/query/sql/src/executor/format.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,14 @@ impl PhysicalPlan {
FormatTreeNode::with_children("Probe".to_string(), vec![probe_child]),
];

let estimated_rows = if let Some(info) = &plan.stat_info {
let _estimated_rows = if let Some(info) = &plan.stat_info {
format!("{0:.2}", info.estimated_rows)
} else {
String::from("None")
};

Ok(FormatTreeNode::with_children(
format!("HashJoin: {} (rows: {})", plan.join_type, estimated_rows),
format!("HashJoin: {}", plan.join_type),
children,
))
}
Expand All @@ -117,14 +117,14 @@ impl PhysicalPlan {
FormatTreeNode::with_children("Right".to_string(), vec![right_child]),
];

let estimated_rows = if let Some(info) = &plan.stat_info {
let _estimated_rows = if let Some(info) = &plan.stat_info {
format!("{0:.2}", info.estimated_rows)
} else {
String::from("none")
};

Ok(FormatTreeNode::with_children(
format!("RangeJoin: {} (rows: {})", plan.join_type, estimated_rows),
format!("RangeJoin: {}", plan.join_type,),
children,
))
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ HashJoin
query T
explain join select * from t right anti join t1 on t1.a = t.a
----
HashJoin: LEFT ANTI (rows: 10.00)
HashJoin: LEFT ANTI
├── Build
│ └── Scan: default.join_reorder.t (read rows: 1)
└── Probe
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ HashJoin
query T
explain join select * from t right anti join t1 on t1.a = t.a
----
HashJoin: LEFT ANTI (rows: 10.00)
HashJoin: LEFT ANTI
├── Build
│ └── Scan: default.join_reorder.t (read rows: 1)
└── Probe
Expand Down
Loading

1 comment on commit 4567c4c

@vercel
Copy link

@vercel vercel bot commented on 4567c4c Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.