Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Mergify merged PR without required test passed #6982

Closed
Xuanwo opened this issue Aug 4, 2022 · 2 comments · Fixed by #6983
Closed

bug: Mergify merged PR without required test passed #6982

Xuanwo opened this issue Aug 4, 2022 · 2 comments · Fixed by #6983
Labels
C-testing Category: testing

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Aug 4, 2022 •
edited

Summary

#6948 has been merged with test_sqllogic_ydb_standalone_linux failed.

Because we write mergify.yml in the way:

- check-success~=^test_sqllogic_(base|ydb)_standalone_linux$

This means check-success base or ydb passed, which is not expected.

We need to change this into:

- check-success=test_sqllogic_base_standalone_linux
- check-success=test_sqllogic_ydb_standalone_linux

cc @ZeaLoVe
@ZeaLoVe
Copy link
Contributor

ZeaLoVe commented Aug 4, 2022

hmmm.. I will fix it.

@leiysky leiysky added the C-testing Category: testing label Aug 4, 2022
@leiysky
Copy link
Member

leiysky commented Aug 4, 2022

By the way, I've fixed the failed test case in #6979

ZeaLoVe added a commit that referenced this issue Aug 4, 2022
@ZeaLoVe
fix mergify config
95e3f11 
issue #6982
@ZeaLoVe ZeaLoVe mentioned this issue Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-testing Category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix mergify config datafuselabs/databend
3 participants
@Xuanwo @ZeaLoVe @leiysky