-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(planner): Introduce bitmap to record applied rules #10024
Conversation
1: Use RuleFactor class classification to manage rule sets 2: Add rule classification to rule
In order to compare the test results later, the old code is retained.
Add MetadataRef for CascadesOptimizer and Memo
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This pull request's description is not fulfill the requirements. @dusx1981 please update it 🙏. The description should contain the following:
|
This pull request's title is not fulfill the requirements. @dusx1981 please update it 🙏. Valid format:
Valid types:
|
src/query/sql/src/planner/optimizer/cascades/tasks/explore_expr.rs
Outdated
Show resolved
Hide resolved
The problem with rule application has been solved and the code can already be reviewed. |
Solve the problem:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Just notice the ticket, let me take a look before merging... |
Hi @dusx1981 , Nice, thanks for your contribution!
|
I think the current tests are covered. The ticket only changes the way to record optimization rules. |
Do I need to change the status to resolved after answering the question? |
Metadata information in CascadesOptimizer and Memo has been removed:) |
LGTM, thanks for the contribution! |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
A draft pr for code review.
closes #9536