refactor(meta/client): add compatible layer for upgrade #10082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
45-compat-err
branch
from
4f3c4e0
to
f5cdd6f
Compare
Currently meta-service responds `KVAppError` for kv-api, which is too big. `MetaAPIError`, which is a sub error of `KVAppError`, would be enough. This is the first step of this change: let the client be able to parse both `KVAppError` and `MetaAPIError`. When this patch is merged, the server side can upgrade to produce just `MetaAPIError`. Changes on client side: Add type `Compatible<Outer, Inner>` as a compatbile enum for both `KVAppError` and `MetaAPIError`. Try to parse a responded error into `Compatible` then extract `MetaAPIError` for use. It no longer uses `KVAppError`, e.g., SchemaApi or ShareApi just relies on a KVApi implementation that just returns MetaError. Changes on server side: The meta sercie still responds `KVAppError`. But some of the error types used internally are adjusted.
drmingdrmer
force-pushed
the
45-compat-err
branch
from
f5cdd6f
to
1e0d026
Compare
ariesdevil
approved these changes
Feb 16, 2023
BohuTANG
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
refactor(meta/client): add compatible layer for upgrade
Currently meta-service responds
KVAppErrorfor kv-api, which is too big.MetaAPIError, which is a sub error ofKVAppError, would be enough.This is the first step of this change: let the client be able to parse
both
KVAppErrorandMetaAPIError. When this patch is merged, theserver side can upgrade to produce just
MetaAPIError.Changes on client side:
Add type
Compatible<Outer, Inner>as a compatbile enum for bothKVAppErrorandMetaAPIError.Try to parse a responded error into
Compatiblethen extractMetaAPIErrorfor use.It no longer uses
KVAppError, e.g., SchemaApi or ShareApi just relieson a KVApi implementation that just returns MetaError.
Changes on server side:
The meta sercie still responds
KVAppError. But some of the error typesused internally are adjusted.
chore(meta/kvapi): MetaGrpcClient does not need to impl KVApi
Changelog
Related Issues