Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): create view check unknown table #10670

Merged
merged 2 commits into from Mar 21, 2023

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Mar 20, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Like this:

postgres=# create view v_t as select * from v_t;
ERROR:  relation "v_t" does not exist
LINE 1: create view v_t as select * from v_t;

Note:

QUERY can query table_functions but only DatabaseCatalog impl list_table_functions. HiveCatalog and IcebergCatalog are unimplemented!(). So I try to modify them to return vec![].

Closes #10669

@vercel
Copy link

vercel bot commented Mar 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Mar 20, 2023 at 8:00AM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Mar 20, 2023
@TCeason TCeason requested review from sundy-li, RinChanNOWWW and BohuTANG and removed request for sundy-li March 20, 2023 08:00
@RinChanNOWWW
Copy link
Member

So we can remove the codes in #10650.

@TCeason
Copy link
Collaborator Author

TCeason commented Mar 20, 2023

So we can remove the codes in #10650.

I think these codes also make sense, so how about keeping them in some last version? This pr is only valid for the next version. It can not cover this case: someone already created a view with an unknown table.

@sundy-li sundy-li merged commit d9b7f4a into datafuselabs:main Mar 21, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: need check table exists when create view
3 participants